Re: git on afs

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Oct 18, 2007, 22:47 UTC
Message-ID: <alpine.LFD.0.999.0710181543380.26902@woody.linux-foundation.org>
In-Reply-To: <20071018203106.GA13518@fries.net>

On Thu, 18 Oct 2007, Todd T. Fries wrote:

> 
> 2) git presumes that DTYPE(de) != DT_DIR .. means the dirent is not a dir
>    this is not true for afs

That's a major bug, and has nothing to do with AFS. Oops.

If you look just a bit lower, you'll see that just a few lines down, git handles DT_UNKNOWN correctly, and just does a lstat() on it as required. I guess that logic should be moved up, or alternatively the exclude logic should be moved down.

Your patch looks ok, but at the same time, I don't think it's really the right thing to do, since it now does that lstat() twice.

		Linus