git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Clean up "git log" format with DIFF_FORMAT_NO_OUTPUT

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Oct 8, 2007, 20:55 UTC
Message-ID
<alpine.LFD.0.999.0710081353290.4964@woody.linux-foundation.org>
In-Reply-To
<alpine.LFD.0.999.0710081342530.4964@woody.linux-foundation.org>
On Mon, 8 Oct 2007, Linus Torvalds wrote:
> 
> This fixes an unnecessary empty line that we add to the log message when 
> we generate diffs, but don't actually end up printing any due to having 
> DIFF_FORMAT_NO_OUTPUT set.

Btw, this seems to break a few tests, where the test assumed the extra newlines at the end of commands like "git show -s" (which also triggered the extra unnecessary padding between commit text and the suppressed diff).

I think the patch is correct, but the tests obviously would need fixing before this patch should be applied.

		Linus
Previous: Linus TorvaldsNext: Linus Torvalds
Message 3 of 4 in “Fix embarrassing "git log --follow" bug”
  1. Linus TorvaldsOct 8, 2007
  2. Clean up "git log" format with DIFF_FORMAT_NO_OUTPUTLinus Torvalds, Oct 8, 2007
  3. Linus TorvaldsOct 8, 2007
  4. [take 2] Clean up "git log" format with DIFF_FORMAT_NO_OUTPUTLinus Torvalds, Oct 9, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.