Re: [PATCH] Make git-clean a builtin

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Oct 8, 2007, 02:17 UTC
Message-ID: <alpine.LFD.0.999.0710071916510.23684@woody.linux-foundation.org>
In-Reply-To: <20071008020435.GA20050@coredump.intra.peff.net>

On Sun, 7 Oct 2007, Jeff King wrote:

Show 5 quoted lines

> 
>   fd = open(".", O_RDONLY);
>   chdir(path);
>   ...
>   fchdir(fd);

fchdir() is not portable.

I think it would be better to not chdir() at all. Yes, that means having to prepend the prefix to the names, but that is what git generally does (for that - and other - reasons).

		Linus