Re: git-log --follow?

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jul 12, 2007, 19:01 UTC
Message-ID: <alpine.LFD.0.999.0707121154240.20061@woody.linux-foundation.org>
In-Reply-To: <7vsl7ttq97.fsf@assigned-by-dhcp.cox.net>

On Thu, 12 Jul 2007, Junio C Hamano wrote:

Show 8 quoted lines

> 
> Yeah, I just tried the blame from 'pu' (I have been carrying
> that original patch from you there).  The output is not very
> intuitive in that it talks about each commit but it is not
> apparent _why_ the command talks about that commit.  Maybe
> adding "there are the lines in the final image of the blob you
> are blaming that came from this commit" to the output would make
> the output easier to read.

That doesn't necessarily work, at least not incrementally. The same commit can show up multiple times for *different* 'blame_entry' things, and I don't think we want to show such a commit multiple times, and I also don't think we know what all the blame entries are going to be until the end.

So right now I use that METAINFO_SHOWN flag to just show the commit once. That makes the log a *lot* more readable.

In my original patch (the one you apparently have in 'pu'), I did that differently (and not very well), but maybe that approach lends itself better to showing some kind of patch.

I think my newer version is likely better.

		Linus