Re: [PATCH 5/5] Add documentation for --window-bytes, pack.windowBytes
- From
Nicolas Pitre <nico@cam.org>
- Date
- Jul 12, 2007, 04:35 UTC
- Message-ID
- <alpine.LFD.0.999.0707120028020.32552@xanadu.home>
- In-Reply-To
- <1184210058514-git-send-email-bdowning@lavos.net>
On Wed, 11 Jul 2007, Brian Downing wrote:
Show 20 quoted lines
> Signed-off-by: Brian Downing <bdowning@lavos.net> > --- > Documentation/config.txt | 5 +++++ > Documentation/git-pack-objects.txt | 8 ++++++++ > Documentation/git-repack.txt | 8 ++++++++ > 3 files changed, 21 insertions(+), 0 deletions(-) > > diff --git a/Documentation/config.txt b/Documentation/config.txt > index aeece84..83c7dc1 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -592,6 +592,11 @@ pack.depth:: > The maximum delta depth used by gitlink:git-pack-objects[1] when no > maximum depth is given on the command line. Defaults to 50. > > +pack.windowBytes:: > + This option provides an additional limit on top of `pack.window`; > + the window size will dynamically scale down so as to not take > + up more than N bytes in memory. > +
This doesn't say what the default (unlimited) is.
Show 18 quoted lines
> pack.compression:: > An integer -1..9, indicating the compression level for objects > in a pack file. -1 is the zlib default. 0 means no > diff --git a/Documentation/git-pack-objects.txt b/Documentation/git-pack-objects.txt > index e3549b5..21ed198 100644 > --- a/Documentation/git-pack-objects.txt > +++ b/Documentation/git-pack-objects.txt > @@ -85,6 +85,14 @@ base-name:: > times to get to the necessary object. > The default value for --window is 10 and --depth is 50. > > +--window-bytes=[N]:: > + This option provides an additional limit on top of `--window`; > + the window size will dynamically scale down so as to not take > + up more than N bytes in memory. This is useful in > + repositories with a mix of large and small objects to not run > + out of memory with a large window, but still be able to take > + advantage of the large window for the smaller objects.
Ditto here.
Also it is a bit akward to specify a size in bytes when you probably want to specify a limit which is in the megabyte range. I'd call them --window_mem and pack.windowmemory, and allow for unit suffixes of 'k', 'm', or 'g' to be supported if not already.
Nicolas