Re: [PATCH] Per-path attribute based hunk header selection.
- From
Nicolas Pitre <nico@cam.org>
- Date
- Jul 9, 2007, 03:22 UTC
- Message-ID
- <alpine.LFD.0.999.0707082320480.26459@xanadu.home>
- In-Reply-To
- <7v8x9tdlbv.fsf@assigned-by-dhcp.cox.net>
On Fri, 6 Jul 2007, Junio C Hamano wrote:
Show 5 quoted lines
> About the comment from Johannes regarding hunk_header vs
> funcname, I would actually prefer hunk_header, since that is
> what this is about ("funcname" and "find_func" were misnomer
> from the beginning), but I'd rename hunk_header to funcname for
> the sake of consistency and minimizing the diff.I think "minimizing the diff" in this case is a bad reason. Using hunk_header is so much better than funcname IMHO.
Nicolas