Re: [PATCH] git-init: set core.worktree if GIT_WORK_TREE is specified

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jul 4, 2007, 16:23 UTC
Message-ID: <alpine.LFD.0.98.0707040920520.9434@woody.linux-foundation.org>
In-Reply-To: <20070704092915.GA18597@moooo.ath.cx>

On Wed, 4 Jul 2007, Matthias Lederhofer wrote:

Show 8 quoted lines

> > +	if (!getcwd(cwd, sizeof(cwd)) || cwd[0] != '/')
> > +		die("Unable to read current working directory");
> 
> Dscho just pointed out that this causes problems on windows.  The same
> is also in setup_git_directory_gently and was there before I touched
> it, introduced by Linus in d288a700.  What was the original reason to
> do this?  Are there implementations of getcwd which return a relative
> path?

Just remove the check for cwd[0] being '/'.

It's just me being too kernel-oriented - inside the kernel, a d_path() return value pathname can be either a real path, or something like "pipe:[8003]", and the difference is the '/' at the beginning.

In user space, and for getcwd(), the check doesn't make sense. So please just remove it, and sorry for my idiotic "I've worked with the kernel for too damn long" programming mistakes.

		Linus