Re: filenames with " b" in them create confusing git diff-tree output

From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Jun 20, 2007, 20:23 UTC
Message-ID: <alpine.LFD.0.98.0706201315310.3593@woody.linux-foundation.org>
In-Reply-To: <7v4pl2v1lf.fsf@assigned-by-dhcp.pobox.com>

On Wed, 20 Jun 2007, Junio C Hamano wrote:

Show 5 quoted lines

> 
> Your example, "a/test b/foo" vs "b/test b/foo", can be and IS
> parsed unambiguously by git-apply (you can try "git apply
> --stat" your example).  IOW, the code to correctly handle it
> already exists ;-)

Well, in all fairness, I *did* hate having to write the code to handle all the name handling in git-apply.

Escaping whitespace (or at least giving the _option_ to do so) might well be a good way to not have to be as smart as git-apply is.

git-apply didn't have that option, since git-apply has as one primary motivation the need to be able to handle patches that come from non-git sources, so git-apply goes to quite some extreme lengths to try to make sense of an inherently rather ambiguous format (that the git diffs then *made* unambiguous, but using pretty subtle rules in order to stay compatible).

Some maybe we should have some generic method of asking for any filename to be quoted in particular ways?

		Linus