git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Problem with git-daemon and mmap.

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Apr 25, 2007, 16:13 UTC
Message-ID
<alpine.LFD.0.98.0704250858530.9964@woody.linux-foundation.org>
In-Reply-To
<20070425074354.GH5942@spearce.org>
On Wed, 25 Apr 2007, Shawn O. Pearce wrote:
> 
> And that was the last window in this packfile.  So we closed it.
> Way to go us.  Our xmmap does not expect release_pack_memory
> to close the fd its about to map...

Yeah, that looks like a real bug - it means that if we only have enough memory to have _one_ window open, the whole pack-file windowing doesn't work.

Now, in this case, it looks like Tim's problem was just some way too tight memory limits by his Debian install, and is fixed for him now, but this does seem to be a beauty wart that should be fixed.

> But that strace above shows a secondary bug when we get into this
> sort of situation.  Not pretty.
Yeah. 
	ulimit -S -v 65536
	git clone linux-2.6 test-linux-2.6

or similar should be able to reproduce it, if you just set the pack-file window to something like 32MB. Maybe.

			Linus
Previous: Shawn O. PearceNext: Alex Riesen
Message 6 of 7 in “Problem with git-daemon and mmap.”
  1. Tim AnsellApr 25, 2007
  2. Gerrit PapeApr 25, 2007
  3. Tim AnsellApr 25, 2007
  4. Gerrit PapeApr 25, 2007
  5. Shawn O. PearceApr 25, 2007
  6. Linus TorvaldsApr 25, 2007
  7. Alex RiesenApr 25, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.