Re: [PATCH/RFC v1 1/1] +5 cases (4 fail), diff whitespace tests
- From
Keith Cascio <keith@cs.ucla.edu>
- Date
- Jan 18, 2009, 19:25 UTC
- Message-ID
- <alpine.GSO.2.00.0901181106150.5969@kiwi.cs.ucla.edu>
- In-Reply-To
- <7vd4elys21.fsf@gitster.siamese.dyndns.org>
On Sat, 17 Jan 2009, Junio C Hamano wrote:
> Hmm. Are these three supposed to be orthogonal?
The semantics of those 3 flags are not orthogonal, no. Their relationship amongst each other is one of transitive implication:
-w implies the other two -b implies --ignore-space-at-eol --ignore-space-at-eol implies only itself
Therefore, it is never *necessary* to specify more than one of these flags on the command line. However, it is not hard to imagine scenarios where software wrappers around git (e.g. GUIs, etc), generate command lines with more than one of these flags. I thought about it, and it seems unreasonable to make it an error to specify more than one, since a new user might not immediately grasp the way they imply each other. I think Git could and should treat it as a legal case. I contacted Dscho about fixing it, but he is busy so I will submit a fix patch myself.