Re: Bug/feature request: Can’t disable fsck warnings during clone

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 4, 2018, 20:28 UTC
Message-ID: <alpine.DEB.2.21.1.1801042125430.32@MININT-6BKU6QN.europe.corp.microsoft.com>
In-Reply-To: <CAF1p0HimkxVydxL3cfRXX0=oaBrmARzYqCbqiarWn1yvh+H-EA@mail.gmail.com>

Hi Kevin,

On Thu, 28 Dec 2017, Kevin A. Mitchell wrote:

Show 42 quoted lines

> I’ve set transfer.fsckObjects to true globally, for safety.
> Unfortunately, this messed up my Spacevim install.
> 
> Doing some digging, I found that some of the repos had a warning. I
> can turn the warning off, but that only affects git fsck, not git
> clone. Turning off transfer.fsckObjects also fixes the problem. I’d
> rather have it on for my development work.
> 
> Tested with the “next” branch as well.
> 
> $ git -c transfer.fsckObjects=true -c fsck.zeroPaddedFilemode=ignore
> clone https://github.com/albfan/ag.vim
> Cloning into 'ag.vim'...
> remote: Counting objects: 1879, done.
> error: object 65e1a0027644b6625b32d30ba5ccf1c4d483480a:
> zeroPaddedFilemode: contains zero-padded file modes
> fatal: Error in object
> fatal: index-pack failed
> $ git —version
> git version 2.15.1.501.g29533fb16
> 
> but this works as expected:
> 
> $ git clone https://github.com/albfan/ag.vim
> Cloning into 'ag.vim'...
> remote: Counting objects: 1879, done.
> remote: Total 1879 (delta 0), reused 0 (delta 0), pack-reused 1879
> Receiving objects: 100% (1879/1879), 1.23 MiB | 2.76 MiB/s, done.
> Resolving deltas: 100% (938/938), done.
> $ cd ag.vim
> $ git -c transfer.fsckObjects=true -c fsck.zeroPaddedFilemode=ignore fsck
> Checking object directories: 100% (256/256), done.
> Checking objects: 100% (1879/1879), done.
> $ git -c transfer.fsckObjects=true fsck
> Checking object directories: 100% (256/256), done.
> warning in tree 65e1a0027644b6625b32d30ba5ccf1c4d483480a:
> zeroPaddedFilemode: contains zero-padded file modes
> Checking objects: 100% (1879/1879), done.
> 
> It would be useful to be able to turn off individual warnings during
> cloning. Is there something I’m missing in the config? Or, is this
> something that could be fixed?

Well, you can apparently have your cake and eat it too (see https://git-scm.com/docs/git-config#git-config-receivefsckltmsg-idgt):

receive.fsck.<msg-id>::
        When `receive.fsckObjects` is set to true, errors can be switched
        to warnings and vice versa by configuring the `receive.fsck.<msg-id>`
        setting where the `<msg-id>` is the fsck message ID and the value
        is one of `error`, `warn` or `ignore`. For convenience, fsck prefixes
        the error/warning with the message ID, e.g. "missingEmail: invalid
        author/committer line - missing email" means that setting
        `receive.fsck.missingEmail = ignore` will hide that issue.

In your case, use receive.fsck.zeroPaddedFilemode=ignore=warn (or =ignore).

Ciao, Johannes