git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: assign only free()able strings to gpg_sign

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 22, 2017, 17:20 UTC
Message-ID
<alpine.DEB.2.21.1.1712221817470.406@MININT-6BKU6QN.europe.corp.microsoft.com>
In-Reply-To
<17655681.1077671513947507373.JavaMail.defaultUser@defaultHost>
Hi Phillip,
On Fri, 22 Dec 2017, phillip.wood@talktalk.net wrote:
> I thought the bug could be triggered when commit.gpgsign was true and 
> it was not overriden on the commandline, is it worth adding a test for 
> that?

Everybody working with extensive test suites seems to write/blog these days that you have to be careful to test meaningfully, i.e. you need to avoid making running the test suite so expensive that developers start to avoid running it.

In that light, what do we want to test? If we want to verify that the gpg_sign is correctly allocated before it is free()d, then the test case I added *already* covers it, and another test case would only increase the runtime of the test suite (which, as I hinted above, I deem a bad thing).

So I'm really in favor of keeping the tests concise.

Ciao, Dscho

Previous: phillip.wood@talktalk.netNext: Junio C Hamano
Message 3 of 5 in “sequencer: assign only free()able strings to gpg_sign”
  1. sequencer: assign only free()able strings to gpg_signJohannes Schindelin, Dec 22, 2017
  2. phillip.wood@talktalk.netDec 22, 2017
  3. Johannes SchindelinDec 22, 2017
  4. Junio C HamanoDec 22, 2017
  5. Junio C HamanoDec 22, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.