git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] git version --build-options: report the build platform, too

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 9, 2017, 14:17 UTC
Message-ID
<alpine.DEB.2.21.1.1712091517240.4318@virtualbox>
In-Reply-To
<20171209094310.GA60808@flurp.local>
Hi Eric,
On Sat, 9 Dec 2017, Eric Sunshine wrote:
Show 20 quoted lines
> On Fri, Dec 08, 2017 at 04:19:25PM -0500, Eric Sunshine wrote:
> > On Fri, Dec 8, 2017 at 4:17 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
> > > On Fri, Dec 8, 2017 at 12:43 PM, Junio C Hamano <gitster@pobox.com> wrote:
> > >> Jonathan Nieder <jrnieder@gmail.com> writes:
> > >>> Can this use GIT_BUILD_PLATFORM directly instead of going via the indirection
> > >>> of a mutable static string?  That is, something like
> > >>>
> > >>>               printf("machine: %s\n", GIT_BUILD_PLATFORM);
> > >>
> > >> Good point.  And if this is externally identified as "machine",
> > >> probably the macro should also use the same word, not "platform".
> > >> We can go either way, as long as we are consistent, though.
> > >
> > > In Autoconf parlance, this would be called "host architecture" (GIT_HOST_ARCH).
> > 
> > My bad: "host cpu", rather (GIT_HOST_CPU).
> 
> Dscho, when you re-roll, perhaps replace the current patch with the
> one below which determines the CPU type automatically rather than
> having to manually maintain and augment a bunch of #ifdefs in help.h.
Will do!

Ciao, Dscho

Previous: Eric SunshineNext: Johannes Schindelin
Message 8 of 19 in “Offer more information in `git version --build-options`'s output”
  1. 0/2 Offer more information in `git version --build-options`'s outputJohannes Schindelin, Dec 8, 2017
  2. 1/2 git version --build-options: report the build platform, tooJohannes Schindelin, Dec 8, 2017
  3. Jonathan NiederDec 8, 2017
  4. Junio C HamanoDec 8, 2017
  5. Eric SunshineDec 8, 2017
  6. Eric SunshineDec 8, 2017
  7. Eric SunshineDec 9, 2017
  8. Johannes SchindelinDec 9, 2017
  9. 2/2 version --build-options: report commit, too, if possibleJohannes Schindelin, Dec 8, 2017
  10. Jonathan NiederDec 8, 2017
  11. Junio C HamanoDec 8, 2017
  12. Johannes SchindelinDec 14, 2017
  13. Johannes SchindelinDec 14, 2017
  14. 0/2 Offer more information in `git version --build-options`'s outputJohannes Schindelin, Dec 14, 2017
  15. 1/2 version --build-options: also report host CPUJohannes Schindelin, Dec 14, 2017
  16. 2/2 version --build-options: report commit, too, if possibleJohannes Schindelin, Dec 14, 2017
  17. Junio C HamanoDec 15, 2017
  18. Eric SunshineDec 15, 2017
  19. Junio C HamanoDec 15, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.