Re: [PATCH v3] diff: support anchoring line(s)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 30, 2017, 00:36 UTC
Message-ID: <alpine.DEB.2.21.1.1711300134560.6482@virtualbox>
In-Reply-To: <20171128184703.155931-1-jonathantanmy@google.com>

Hi Jonathan,

On Tue, 28 Nov 2017, Jonathan Tan wrote:

Show 12 quoted lines

> @@ -4607,7 +4627,14 @@ int diff_opt_parse(struct diff_options *options,
>  		DIFF_XDL_CLR(options, NEED_MINIMAL);
>  		options->xdl_opts &= ~XDF_DIFF_ALGORITHM_MASK;
>  		options->xdl_opts |= value;
> +		if (value == XDF_PATIENCE_DIFF)
> +			clear_patience_anchors(options);
>  		return argcount;
> +	} else if (skip_prefix(arg, "--anchored=", &arg)) {
> +		options->xdl_opts = DIFF_WITH_ALG(options, PATIENCE_DIFF);
> +		ALLOC_GROW(options->anchors, options->anchors_nr + 1,
> +			   options->anchors_alloc);
> +		options->anchors[options->anchors_nr++] = xstrdup(arg);

I looked and failed to find the code that releases this array after the diff is done... did I miss anything?

Ciao, Dscho