Re: Git 2.15.0 on OSX 10.12.6: gui multi-select stage

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 1, 2017, 21:58 UTC
Message-ID: <alpine.DEB.2.21.1.1711012254380.6482@virtualbox>
In-Reply-To: <CAKbB5OwxQ4XtLXuu2w3QmuKryA=3iHupz=y0m2E1NH+Dwzd8Xw@mail.gmail.com>

Hi Matthew,

On Wed, 1 Nov 2017, Matthew Orres wrote:

Show 12 quoted lines

> Using 2.15.0 on OSX 10.12.6, when I open git gui, and then attempt to
> stage multiple files as such:
> 
> * Left click first file
> * CMD+Shift+Click last file to multi-select all files
> * CMT+T (shortcut for Stage to Commit)
> 
> Only the file I selected with the first Left Click is staged and my
> selection disappears.
> 
> I'd be happy to provide more system-level info if there's issues with
> reproducing this on other machines.

Maybe you'll be also happy to test things?

I believe that we carry a fix for this in Git for Windows: https://github.com/git-for-windows/git/commit/3a5640fd3f0aa57edecc8dab455a97c5a15e6626

The easiest way to test this would be to simply build Git from the `master` branch of https://github.com/git-for-windows/git (I try to keep it building and passing the test suite at all times not only on Windows, but also on Linux, it should also work on macOS).

Ciao, Johannes

P.S.: If you test this, and can confirm that it fixes your issue, I'll get this patch submitted properly to the Git mailing list (sadly, it seems that the https://github.com/patthoyts/git-gui project is sleeping beauty mode for a while now, otherwise I would add PRs there).