git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: pass absolute GIT_DIR to exec commands

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 1, 2017, 21:14 UTC
Message-ID
<alpine.DEB.2.21.1.1711012214220.6482@virtualbox>
In-Reply-To
<20171031230733.18949-1-jacob.e.keller@intel.com>
Hi Jake,
On Tue, 31 Oct 2017, Jacob Keller wrote:
Show 22 quoted lines
> From: Jacob Keller <jacob.keller@gmail.com>
> 
> When we replaced the old shell script based interactive rebase in
> commmit 18633e1a22a6 ("rebase -i: use the rebase--helper builtin",
> 2017-02-09) we introduced a regression of functionality in that the
> GIT_DIR would be sent to the environment of the exec command as-is.
> 
> This generally meant that it would be passed as "GIT_DIR=.git", which
> causes problems for any exec command that wants to run git commands in
> a subdirectory.
> 
> This isn't a very large regression, since it is not that likely that the
> exec command will run a git command, and even less likely that it will
> need to do so in a subdir. This regression was discovered by a build
> system which uses git-describe to find the current version of the build
> system, and happened to do so from the src/ sub directory of the
> project.
> 
> Fix this by passing in the absolute path of the git directory into the
> child environment.
> 
> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>

ACK, Dscho

Previous: Jacob Keller
Message 2 of 2 in “sequencer: pass absolute GIT_DIR to exec commands”
  1. sequencer: pass absolute GIT_DIR to exec commandsJacob Keller, Oct 31, 2017
  2. Johannes SchindelinNov 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.