Re: [PATCH v2] git: add --no-optional-locks option

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 28, 2017, 16:15 UTC
Message-ID: <alpine.DEB.2.21.1.1709281813130.40514@virtualbox>
In-Reply-To: <20170927065430.cssyxxsxjhp7k4ye@sigill.intra.peff.net>

Hi Peff,

On Wed, 27 Sep 2017, Jeff King wrote:

Show 5 quoted lines

> For the other comments on v1, I decided not to make any changes:
> 
>   - JSixt suggested marking this as a local-repo variable. I think we
>     really do want it to cross repo boundaries to handle submodules (and
>     the GfW version does the same).

Indeed. We had it originally as a local-repo only variable, and you probably guessed that submodules made us rethink that approach.

Show 5 quoted lines

>   - there was some discussion of alternatives, including reader/writer
>     locking schemes and lock-retry timeouts for other callers. This
>     approach has the benefit of simplicity and having been tested in the
>     real world by GfW/VS.  I wouldn't mind if somebody wanted to explore
>     lock retries, but I think we'd want to have this feature regardless.

We also weighed other options, and took this route for simplicity. It's possible to explain during an uninterrupted elevator ride what it does. Makes for less bugs.

And yes, we wanted to test it first before showing it to the Git mailing list ;-)

Ciao, Dscho