git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Commit dropped when swapping commits with rebase -i -p

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Sep 1, 2017, 19:16 UTC
Message-ID
<alpine.DEB.2.21.1.1709012116060.4132@virtualbox>
In-Reply-To
<CAHGBnuO0dviVr0zD+KqANc6Ju8-cZh2KLbLz6NH3h+jprRzbaw@mail.gmail.com>
Hi Sebastian,
On Wed, 30 Aug 2017, Sebastian Schuberth wrote:
Show 18 quoted lines
> On Wed, Aug 30, 2017 at 10:28 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> 
> > Please see 'exchange two commits with -p' in t3404. This is a known
> 
> Thank for pointing out the test.
> 
> > breakage, and due to the fact that -p and -i are fundamentally
> > incompatible with one another (even if -p's implementation was based on
> > -i's). I never had in mind for -p to be allowed together with -i, and was
> > against allowing it because of the design.
> 
> In any case, I wouldn't have expected *that* kind of side effect for
> such a simple case (that does not involve any merge commits).
> 
> If these options are fundamentally incompatible as you say, would you
> agree that it makes sense to disallow their usage together (instead of
> just documenting that you should know what you're doing)?

As I said already, I agreed with you before you said it, but I was overruled.

Ciao, Johannes

Previous: Sebastian Schuberth
Message 12 of 12 in “Commit dropped when swapping commits with rebase -i -p”
  1. Sebastian SchuberthAug 30, 2017
  2. Martin ÅgrenAug 30, 2017
  3. Sebastian SchuberthAug 30, 2017
  4. Jonathan NiederSep 2, 2017
  5. Sebastian SchuberthSep 11, 2017
  6. Junio C HamanoSep 15, 2017
  7. Andreas HeidukSep 16, 2017
  8. Sebastian SchuberthSep 16, 2017
  9. Phillip WoodSep 17, 2017
  10. Johannes SchindelinAug 30, 2017
  11. Sebastian SchuberthAug 30, 2017
  12. Johannes SchindelinSep 1, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.