Re: [RFC 0/3] imap-send curl tunnelling support

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Aug 23, 2017, 22:35 UTC
Message-ID: <alpine.DEB.2.21.1.1708240033440.19382@virtualbox>
In-Reply-To: <63e3ebea-ad4e-14d7-1170-594390af8e06@kdbg.org>

Hi Hannes,

On Tue, 22 Aug 2017, Johannes Sixt wrote:

Show 13 quoted lines

> Am 21.08.2017 um 09:27 schrieb Nicolas Morey-Chaisemartin:
> > (Sent a reply from my phone while out of town but couldn't find it so here
> > it is again)
> > 
> > It's available on my github:
> > https://github.com/nmorey/git/tree/dev/curl-tunnel
> > 
> > The series had been stlighly changed since the patch were posted, mostly to
> > add the proper ifdefs to handle older curl versions.
> 
> This does not build for me on Windows due to a missing socketpair() function.
> But I am working in an old environment, so I do not know whether this
> statement has much value.

Same problem in Git for Windows' SDK:

imap-send.c: In function 'setup_tunnel':
imap-send.c:936:6: error: implicit declaration of function 'socketpair'; did you
 mean 'socket'? [-Werror=implicit-function-declaration]
  if (socketpair(AF_UNIX, SOCK_STREAM, 0, sock_fds))
      ^~~~~~~~~~
      socket
imap-send.c: In function 'curl_tunnel_socket':
imap-send.c:1416:9: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
  return (unsigned long)clientp;
         ^