Re: [PATCH] win32: plug memory leak on realloc() failure in syslog()
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 14, 2017, 20:26 UTC
- Message-ID
- <alpine.DEB.2.21.1.1708142225330.19382@virtualbox>
- In-Reply-To
- <245410ce-1f4c-f2a9-fd8d-98ff2d2c0335@web.de>
Hi René,
On Thu, 10 Aug 2017, René Scharfe wrote:
> If realloc() fails then the original buffer is still valid. Free it > before exiting the function. > > Signed-off-by: Rene Scharfe <l.s.r@web.de>
The subject had me worried for a second... The realloc() fails so rarely that I, for one, have never encountered that problem.
Still, it is a correct fix for a real bug.
Thanks, Dscho