git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-path-utils: handle const parameter of basename and dirname

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 7, 2017, 21:15 UTC
Message-ID
<alpine.DEB.2.21.1.1708072314420.4271@virtualbox>
In-Reply-To
<5bfd3c7c-c3c8-5115-713a-63f6f8cd7eb7@web.de>
Hi René,
On Mon, 7 Aug 2017, René Scharfe wrote:
Show 12 quoted lines
> The parameter to basename(3) and dirname(3) traditionally had the type
> "char *", but on OpenBSD it's been "const char *" for years.  That
> causes (at least) Clang to throw an incompatible-pointer-types warning
> for test-path-utils, where we try to pass around pointers to these
> functions.
> 
> Avoid this warning (which is fatal in DEVELOPER mode) by ignoring the
> promise of OpenBSD's implementations to keep input strings unmodified
> and enclosing them in POSIX-compatible wrappers.
> 
> Signed-off-by: Rene Scharfe <l.s.r@web.de>
> ---
This patch is Fine By Me.

Thanks, Dscho

Previous: René Scharfe
Message 2 of 2 in “test-path-utils: handle const parameter of basename and dirname”
  1. test-path-utils: handle const parameter of basename and dirnameRené Scharfe, Aug 7, 2017
  2. Johannes SchindelinAug 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.