git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 6/6] Use the early config machinery to expand aliases

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jun 14, 2017, 10:21 UTC
Message-ID
<alpine.DEB.2.21.1.1706141221020.171564@virtualbox>
In-Reply-To
<20170614060502.ljuvdxcbara3zfjx@sigill.intra.peff.net>
Hi Peff,
On Wed, 14 Jun 2017, Jeff King wrote:
Show 22 quoted lines
> On Tue, Jun 13, 2017 at 09:21:30AM -0700, Junio C Hamano wrote:
> 
> > >  alias.c          | 31 ++++++++++++++++++++++++-------
> > >  git.c            | 55 ++++---------------------------------------------------
> > >  t/t7006-pager.sh |  2 +-
> > >  3 files changed, 29 insertions(+), 59 deletions(-)
> > 
> > Happy to see the deletion of all the save/restore-env stuff.
> > 
> > Except for the puzzlement in one paragraph in the log, looks very
> > good.  Thanks for a pleasant reading.
> 
> The whole thing looks good to me, too, though we should decide what to
> do with the point that Brandon raised.
> 
> As far as the "streamline" puzzlement goes, I'm OK with either of:
> 
>   - taking your suggestion from the other thread and actually doing that
>     streamlining, which is one less thing to have to explain
> 
>   - leaving the code as-is and tweaking the commit message (though it
>     made sense to me)

I fixed the thing in the way you suggested (which worked after Junio hit me with the cluebat about skip_prefix() and git_config_string()).

Ciao, Dscho

Previous: Jeff KingNext: Johannes Schindelin
Message 10 of 15 in “Avoid problem where git_dir is set after alias expansion”
  1. 0/6 Avoid problem where git_dir is set after alias expansionJohannes Schindelin, Jun 13, 2017
  2. 1/6 discover_git_directory(): avoid setting invalid git_dirJohannes Schindelin, Jun 13, 2017
  3. 3/6 help: use early config when autocorrecting aliasesJohannes Schindelin, Jun 13, 2017
  4. 2/6 config: report correct line number upon errorJohannes Schindelin, Jun 13, 2017
  5. 4/6 t1308: relax the test verifying that empty alias values are disallowedJohannes Schindelin, Jun 13, 2017
  6. 5/6 t7006: demonstrate a problem with aliases in subdirectoriesJohannes Schindelin, Jun 13, 2017
  7. 6/6 Use the early config machinery to expand aliasesJohannes Schindelin, Jun 13, 2017
  8. Junio C HamanoJun 13, 2017
  9. Jeff KingJun 14, 2017
  10. Johannes SchindelinJun 14, 2017
  11. Johannes SchindelinJun 14, 2017
  12. Brandon WilliamsJun 13, 2017
  13. Jeff KingJun 14, 2017
  14. Johannes SchindelinJun 14, 2017
  15. Brandon WilliamsJun 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.