Re: [PATCH v3 6/6] Use the early config machinery to expand aliases
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 14, 2017, 10:21 UTC
- Message-ID
- <alpine.DEB.2.21.1.1706141221020.171564@virtualbox>
- In-Reply-To
- <20170614060502.ljuvdxcbara3zfjx@sigill.intra.peff.net>
Hi Peff,
On Wed, 14 Jun 2017, Jeff King wrote:
Show 22 quoted lines
> On Tue, Jun 13, 2017 at 09:21:30AM -0700, Junio C Hamano wrote: > > > > alias.c | 31 ++++++++++++++++++++++++------- > > > git.c | 55 ++++--------------------------------------------------- > > > t/t7006-pager.sh | 2 +- > > > 3 files changed, 29 insertions(+), 59 deletions(-) > > > > Happy to see the deletion of all the save/restore-env stuff. > > > > Except for the puzzlement in one paragraph in the log, looks very > > good. Thanks for a pleasant reading. > > The whole thing looks good to me, too, though we should decide what to > do with the point that Brandon raised. > > As far as the "streamline" puzzlement goes, I'm OK with either of: > > - taking your suggestion from the other thread and actually doing that > streamlining, which is one less thing to have to explain > > - leaving the code as-is and tweaking the commit message (though it > made sense to me)
I fixed the thing in the way you suggested (which worked after Junio hit me with the cluebat about skip_prefix() and git_config_string()).
Ciao, Dscho