Re: [PATCH 0/2] Fix warnings on access of a remote with Windows paths

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 23, 2017, 10:46 UTC
Message-ID: <alpine.DEB.2.21.1.1705231245300.3610@virtualbox>
In-Reply-To: <1542d54f-d530-b60d-3270-d9b4e94c814d@kdbg.org>

Hi Hannes,

On Mon, 22 May 2017, Johannes Sixt wrote:

Show 23 quoted lines

> Am 22.05.2017 um 16:01 schrieb Johannes Schindelin:
> > On Mon, 22 May 2017, stefan.naewe@atlas-elektronik.com wrote:
> > > Am 20.05.2017 um 08:28 schrieb Johannes Sixt:
> > > > This small series fixes these warnings on Windows:
> > > >
> > > > C:\Temp\gittest>git fetch C:\Temp\gittest
> > > > warning: unable to access '.git/remotes/C:\Temp\gittest': Invalid
> > > > warning: argument
> > > > warning: unable to access '.git/branches/C:\Temp\gittest': Invalid
> > > > warning: argument
> > > >  From C:\Temp\gittest
> > > >   * branch            HEAD       -> FETCH_HEAD
> > >
> > > What is the exact precondition to get such a warning ?
> > >
> > > Just wondering, because I'm not able to reproduce that warning
> > > (with Git4win version 2.13.0.windows.1).
> > 
> > I had tested this also, and came to the conclusion that only Hannes'
> > MSys-based custom version is affected that is much closer to git.git's
> > `master` than to Git for Windows' fork.
> 
> In this case, the warning occurs because I build with nd/fopen-errors.

Ah. So the base commit Junio chose for your v1 is completely inappropriate. It should be nd/fopen-errors instead.

Thanks for the clarification! Dscho