Re: [PATCH v2 1/1] t0027: tests are not expensive; remove t0025

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 2, 2017, 16:11 UTC
Message-ID: <alpine.DEB.2.20.1705021809340.3480@virtualbox>
In-Reply-To: <20170502155631.24848-1-tboegi@web.de>

Hi Bögi,

On Tue, 2 May 2017, tboegi@web.de wrote:

Show 11 quoted lines

> From: Torsten Bögershausen <tboegi@web.de>
> 
> The purpose of t0027 is to test all CRLF related conversions at
> "git checkout" and "git add".
> 
> Running t0027 under Git for Windows takes 3-4 minutes, so the whole script
> had been marked as "EXPENSIVE".
> 
> The source code for "Git for Windows" overrides this since 2014:
> "t0027 is marked expensive, but really, for MinGW we want to run these
> tests always."

Indeed.

Show 5 quoted lines

> Recent "stress" tests show that t0025 if flaky, reported by Lars Schneider,
> larsxschneider@gmail.com
> 
> All tests from t0025 are covered in t0027 already, so that t0025 can be
> retiered:

s/retiered/retired/

Show 6 quoted lines

> The execution time for t0027 is 14 seconds under Linux,
> and 63 seconds under Mac Os X.
> And in case you ask, things are not going significantly faster using a SSD
> instead of a spinning disk.
> 
> Signed-off-by: Torsten Bögershausen <tboegi@web.de>

Thank you for this patch.

Apart from the tyop, would it be possible to fix the formatting to look less strange? (Unless you use this to transport a super-secret message steganographically to an alien planet or some such, of course.)

Ciao, Dscho