RE: [PATCH] Increase core.packedGitLimit
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Apr 21, 2017, 09:34 UTC
- Message-ID
- <alpine.DEB.2.20.1704211131310.3480@virtualbox>
- In-Reply-To
- <4c111acb3f134aa9aef8648d75bd741f@exmbdft7.ad.twosigma.com>
Hi Dave,
On Thu, 20 Apr 2017, David Turner wrote:
Show 6 quoted lines
> > We might want to think about replacing git_config_ulong with > git_config_size_t in nearly all cases. "long" has ceased to be > useful. More modern versions of C prefer uint64_t, but I > think that we'll usually want size_t because these values will > be used as memory limits of various sorts.
Indeed, `unsigned long` has ceased to be useful ever since the introduction of inttypes.h. It is just too undefined.
We probably also need git_config_off_t(), though, and maybe even git_config_ssize_t().
I would definitely welcome a change in direction where we use datatypes also as a documentation of the variables' purpose.
Ciao, Dscho