git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sha1dc: safeguard against outside definitions of BIGENDIAN

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 27, 2017, 15:39 UTC
Message-ID
<alpine.DEB.2.20.1703271739210.14958@virtualbox>
In-Reply-To
<xmqqwpbd46gd.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Sat, 25 Mar 2017, Junio C Hamano wrote:
Show 12 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Which leads me to wonder if a more robust solution that is in line
> > with the original design of sha1dc/sha1.c code may be to do an
> > unconditional "#undef BIGENDIAN" before the above block, so that no
> > matter what the calling environment sets BIGENDIAN to (including
> > "0"), it gets ignored and we always use the auto-selection.
> 
> So here is what I came up with as a replacement (this time as a
> proper patch not a comment on a patch).
> 
> Dscho, could you see if this fixes your build?
The Continuous Testing is back to normal, thanks.

Ciao, Johannes

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 5 in “sha1dc: safeguard against outside definitions of BIGENDIAN”
  1. sha1dc: safeguard against outside definitions of BIGENDIANJohannes Schindelin, Mar 24, 2017
  2. Junio C HamanoMar 25, 2017
  3. Junio C HamanoMar 25, 2017
  4. Johannes SchindelinMar 27, 2017
  5. Junio C HamanoMar 27, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.