Re: [PATCH] Travis: also test on 32-bit Linux
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 28, 2017, 20:34 UTC
- Message-ID
- <alpine.DEB.2.20.1702282019460.3767@virtualbox>
- In-Reply-To
- <c76a133a57514a332828099d342c9763fd946bfa.1488309430.git.johannes.schindelin@gmx.de>
Hi,
On Tue, 28 Feb 2017, Johannes Schindelin wrote:
Show 10 quoted lines
> When Git v2.9.1 was released, it had a bug that showed only on Windows > and on 32-bit systems: our assumption that `unsigned long` can hold > 64-bit values turned out to be wrong. > > This could have been caught earlier if we had a Continuous Testing set > up that includes a build and test run on 32-bit Linux. > > Let's do this (and take care of the Windows build later). This patch > asks Travis CI to install a Docker image with 32-bit libraries and then > goes on to build and test Git using this 32-bit setup.
For the record, I first tested this with the LONG_IS_32BIT flag forced to `true` so that the date tests must fail. They did fail as expected (search for "not ok" in this output):
https://travis-ci.org/git/git/jobs/206199002
(I actually cannot see the log right now, Travis seems to be under heavy load...)
A much cleaned up version that does not force that LONG_IS_32BIT produced this log:
https://travis-ci.org/git/git/jobs/206228708
(Same here, my browser fails to load the log, probably because Travis experiences quite high a load...)
Please note that this approach is not without problems. It would appear that Travis currently has serious problems to even *reach* the Docker Hub, and therefore cannot download the Docker image:
https://travis-ci.org/git/git/jobs/206292947#L6
Ciao, Johannes