git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] t7800: replace "wc -l" with test_line_count

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Feb 7, 2017, 12:02 UTC
Message-ID
<alpine.DEB.2.20.1702071300021.3496@virtualbox>
In-Reply-To
<20170207091700.20156-2-davvid@gmail.com>
Hi David,
On Tue, 7 Feb 2017, David Aguilar wrote:
> Make t7800 easier to debug by capturing output into temporary files and
> using test_line_count to make assertions on those files.
> 
> Signed-off-by: David Aguilar <davvid@gmail.com>
Both patches look like an obvious improvement with no obvious bugs to me.

In this case, I allowed myself to forego the more thorough code review in favor of merely glancing over the diffs, seeing as the changes do not really need a lot of context.

Thank you, Johannes

Previous: David Aguilar
Message 3 of 3 in “t7800: simplify basic usage test”
  1. 1/2 t7800: simplify basic usage testDavid Aguilar, Feb 7, 2017
  2. 2/2 t7800: replace "wc -l" with test_line_countDavid Aguilar, Feb 7, 2017
  3. Johannes SchindelinFeb 7, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.