git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] fixup! worktree move: new command

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 30, 2017, 12:24 UTC
Message-ID
<alpine.DEB.2.20.1701301317500.3469@virtualbox>
In-Reply-To
<xmqqwpdgz8zq.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Fri, 27 Jan 2017, Junio C Hamano wrote:
> The tip of 'pu' (or anything beyond the tip of 'jch') is not always
> expected to pass test or even build, [...]
This makes `pu` a lot less useful than it could be.

And we could easily improve the situation simply by changing the rule ever so slightly: when a build, or a test, fails in `pu` and there exists a fix, this fix should go into `pu` ASAP.

As you point out later in your mail, the fixup! or SQUASH! commit is a very convenient reminder that a particular branch is still "under construction". That is, changing the rule as I proposed above will not only help the Continuous Integration [*1*] to avoid reporting duplicates, it will also help us improve the project faster.

Ciao, Johannes

Footnote *1*: It appears that there may be the misconception floating around that Continuous Integration is designed to annoy developers by pointing out unportable or unbuildable code. Once you realize, though, that it detects and reports code that is below our existing code's quality, no doubt you will agree that it is a convenient tool to relieve reviewers from tedious work that can be done by a machine as well.

Previous: Junio C Hamano
Message 4 of 4 in “fixup! worktree move: new command”
  1. fixup! worktree move: new commandJohannes Schindelin, Jan 25, 2017
  2. Johannes SchindelinJan 27, 2017
  3. Junio C HamanoJan 27, 2017
  4. Johannes SchindelinJan 30, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.