Re: [PATCH v2 0/7] Macros for Asciidoctor support

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 25, 2017, 13:28 UTC
Message-ID: <alpine.DEB.2.20.1701251425080.3469@virtualbox>
In-Reply-To: <20170122024156.284180-1-sandals@crustytoothpaste.net>

Hi Brian,

On Sun, 22 Jan 2017, brian m. carlson wrote:

Show 12 quoted lines

> There are two major processors of AsciiDoc: AsciiDoc itself, and
> Asciidoctor.  Both have advantages and disadvantages, but traditionally
> the documentation has been built with AsciiDoc, leading to some
> surprising breakage when building with Asciidoctor.  Partially, this is
> due to the need to specify a significant number of macros on the command
> line when building with Asciidoctor.
> 
> This series cleans up some issues building the documentation with
> Asciidoctor and provides two knobs, USE_ASCIIDOCTOR, which controls
> building with Asciidoctor, and ASCIIDOCTOR_EXTENSIONS_LAB, which
> controls the location of the Asciidoctor Extensions Lab, which is
> necessary to expand the linkgit macro.

I like it.

I reviewed all the patches and think they are good (except the XSLT patch, which made me just feel incompetent because I do not know enough to have an opinion about it).

> The need for the extensions could be replaced with a small amount of
> Ruby code, if that's considered desirable.  Previous opinions on doing
> so were negative, however.

Quite frankly, it is annoying to be forced to install the extensions. I would much rather have the small amount of Ruby code in Git's repository.

Thanks, Johannes