Re: [PATCH v2 3/3] mingw: replace isatty() hack

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 22, 2016, 23:18 UTC
Message-ID: <alpine.DEB.2.20.1612230017030.155951@virtualbox>
In-Reply-To: <04859cf9-e67a-28ab-ccb3-249687e696c8@kdbg.org>

Hi Hannes,

On Thu, 22 Dec 2016, Johannes Sixt wrote:

Show 16 quoted lines

> Am 22.12.2016 um 22:37 schrieb Johannes Schindelin:
>
> > Would you have a suggestion how to rephrase the comment to make it
> > less confusing?
> 
> Perhaps
> 
> 	 * This might close the cached console handle.
> 	 * We must cache the live duplicate instead.
> 
> Then update the cache before the dup2, because at this time all 3 of console,
> handle, and duplicate are live and cannot be recycled:
> 
> 	if (console == handle)
> 		console = duplicate;
> 	dup2(new_fd, fd);

Good point. I reworded the comment slightly differently (see the interdiff in v3 0/3), hope you don't mind.

Ciao, Dscho

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.