Re: [PATCH v1 2/2] read-cache: make sure file handles are not inherited by child processes
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 6, 2016, 11:41 UTC
- Message-ID
- <alpine.DEB.2.20.1609061339230.129229@virtualbox>
- In-Reply-To
- <20160905211111.72956-3-larsxschneider@gmail.com>
Hi Lars,
On Mon, 5 Sep 2016, larsxschneider@gmail.com wrote:
> [... commit message ...]
Makes sense.
Show 10 quoted lines
> diff --git a/read-cache.c b/read-cache.c
> index 491e52d..02f74d3 100644
> --- a/read-cache.c
> +++ b/read-cache.c
> @@ -156,7 +156,7 @@ void fill_stat_cache_info(struct cache_entry *ce, struct stat *st)
> static int ce_compare_data(const struct cache_entry *ce, struct stat *st)
> {
> int match = -1;
> - int fd = open(ce->name, O_RDONLY);
> + int fd = open(ce->name, O_RDONLY | O_CLOEXEC);Eric's comment on 1/2 applies here, too, of course: should this cause any problems on non-Windows platforms, we always have that FD_CLOEXEC thing that we could probably use to fix it.
But let's cross that bridge when (or better: if) we get there.
Ciao, Dscho