Re: [PATCH] introduce hex2chr() for converting two hexadecimal digits to a character

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sep 4, 2016, 07:49 UTC
Message-ID: <alpine.DEB.2.20.1609040947211.129229@virtualbox>
In-Reply-To: <ac454d89-e1cc-083e-5cea-fc9751de9a0f@web.de>

Hi René,

On Sat, 3 Sep 2016, René Scharfe wrote:

> Add and use a helper function that decodes the char value of two
> hexadecimal digits.  It returns a negative number on error, avoids
> running over the end of the given string and doesn't shift negative
> values.

I like it! Maybe stress a little bit why this is a good change? Like, DRY up code, makes the code safer (bt avoiding shifting negative values)?

>  6 files changed, 21 insertions(+), 78 deletions(-)

Very, very nice!

Thanks, Dscho