git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] make rebase respect core.hooksPath if set

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Aug 15, 2016, 12:24 UTC
Message-ID
<alpine.DEB.2.20.1608151422210.4924@virtualbox>
In-Reply-To
<CAKkAvaxWk6SK4EYPaWXHQoVBh9qLgHoEqAh9+dgOrjncsi5QyA@mail.gmail.com>
Hi ryenus,
On Sun, 14 Aug 2016, ryenus wrote:
> when looking for pre-rebase and post-rewrite hooks, git-rebase
> only looks for hooks dir using `git rev-parse --git-path hooks`,
> which didn't consider the path overridden by core.hooksPath.

Would it not be more appropriate to teach --git-path hooks to respect the core.hooksPath variable? This would be in line with --git-path objects respecting the GIT_OBJECT_DIRECTORY environment variable.

> Signed-off-by: ryenus <ryenus@gmail.com>

From https://github.com/git/git/blob/v2.9.3/Documentation/SubmittingPatches#L290-L291

> Also notice that a real name is used in the Signed-off-by: line. Please
> don't hide your real name.

Thanks, Johannes

Previous: Mike RappazzoNext: Jeff King
Message 4 of 6 in “make rebase respect core.hooksPath if set”
  1. make rebase respect core.hooksPath if setryenus, Aug 14, 2016
  2. ryenusAug 14, 2016
  3. Mike RappazzoAug 14, 2016
  4. Johannes SchindelinAug 15, 2016
  5. Jeff KingAug 15, 2016
  6. ryenusAug 16, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.