Re: [PATCH] commit: Fix description of no-verify

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 26, 2016, 12:55 UTC
Message-ID: <alpine.DEB.2.20.1607261452281.14111@virtualbox>
In-Reply-To: <1469519305-11361-1-git-send-email-orgad.shaneh@audiocodes.com>

Hi Orgad

On Tue, 26 Jul 2016, Orgad Shaneh wrote:

> From: Orgad Shaneh <orgads@gmail.com>

This is unnecessary, as it matches your email address.

> include also commit-msg hook.

This comment was a bit cryptic, until I read the patch. Now I find that comment redundant with the patch.

However, I think that...

> -		OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit hook")),
> +		OPT_BOOL('n', "no-verify", &no_verify, N_("bypass pre-commit and commit-msg hooks")),

... it may be more desirable to future-proof this simply by saying "bypass hooks".

In the alternative, it would be good if the commit message could convincingly make the case that there are no other hooks that will be skipped with -n.

Of course, I could go and look at the source code to convince myself. But it is really the duty of the commit message to be already convincing enough.

Ciao, Dscho