Re: Bug: "git log --format='format:%+s%+b'" doesn't insert newline before body

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 25, 2016, 07:33 UTC
Message-ID: <alpine.DEB.2.20.1607250926320.14111@virtualbox>
In-Reply-To: <8915446.47C9zkNvuX@photon>

Hi Ilya,

On Sun, 24 Jul 2016, Ilya Tumaykin wrote:

Show 21 quoted lines

> Steps to reproduce:
> $ git init
> $ >123
> $ git add 123
> $ git commit -v -m 'This is subject' -m 'And this is body'
> $ git --no-pager log -1 --format='format:%+s%+b'
> 
> Actual results:
> ```
> 
> This is subject
> And this is body
> ```
> 
> Expected results:
> ```
> 
> This is subject
> 
> And this is body
> ```

The empty line between commit subject and body is neither part of the subject nor of the body. That means that the above-mentioned expectation was incorrect.

Unless you somehow allow empty commit messages (Git does not, unless you play games with low-level commands), the second '+' is unnecessarily conditional. Therefore "%s%n%+b" *might* do what you intended (I would not know, because that information was missing from the report).

Ciao, Johannes