Re: [ANN] Pro Git Reedited 2nd Edition

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 25, 2016, 07:04 UTC
Message-ID: <alpine.DEB.2.20.1607250900260.14111@virtualbox>
In-Reply-To: <89e0a631-6396-e56e-0c1d-37acdbf8eda4@gmail.com>

Hi Jon,

On Sun, 24 Jul 2016, Jon Forrest wrote:

Show 14 quoted lines

> On 7/24/2016 11:27 AM, Jakub Narębski wrote:
> 
> > All right. One issue I have after browsing through changes is that
> > description of changes and their granularity is severely lacking.  "A
> > few more very minor changes.", "More piddly changes.", "should have
> > included this in last commit" are not good commit messages.
> 
> You're absolutely right. I probably should have squashed those commits.
> Those comments aren't really intended for public consumption.
> Since I made many changes per commit, I really couldn't give an
> instructive commit message.
> 
> Now that this edition is done, I plan on following good commit
> practices in the future.

For the record: I found it a good practice to clean up my commits (read: reword commit messages, split/join commits) *even after* pushing them to a public repository.

Interactive rebase to the rescue.

That practice is not solely for others' benefit, by the way.

You will most likely find that it not only structures your work better, you will also find that it turns up things that were forgotten and still need to be addressed.

Ciao, Johannes