Re: [PATCH v2] blame: Allow to blame paths freshly added to the index
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jul 15, 2016, 15:28 UTC
- Message-ID
- <alpine.DEB.2.20.1607151726370.6426@virtualbox>
- In-Reply-To
- <20160715125550.24883-1-mh@glandium.org>
Hi Mike,
On Fri, 15 Jul 2016, Mike Hommey wrote:
Show 21 quoted lines
> diff --git a/t/t8003-blame-corner-cases.sh b/t/t8003-blame-corner-cases.sh
> index a9b266f..2812d7c 100755
> --- a/t/t8003-blame-corner-cases.sh
> +++ b/t/t8003-blame-corner-cases.sh
> @@ -41,12 +41,12 @@ test_expect_success setup '
> test_tick &&
> GIT_AUTHOR_NAME=Fourth git commit -m Fourth &&
>
> - {
> - echo ABC
> - echo DEF
> - echo XXXX
> - echo GHIJK
> - } >cow &&
> + cat >cow <<-\EOF &&
> + ABC
> + DEF
> + XXXX
> + GHIJK
> + EOF
> git add cow &&Sorry, I did not realize that there was precedent for this awkward paradigm in the same test script.
I like that you fix them, but I would prefer that to be done in a separate patch (does not even need to be the same patch series).
Apart from that (i.e. apart from touching unrelated parts of the test script), the patch looks good to me.
Thanks, Dscho