Re: [PATCH 5/5] Skip blank lines when matching <commit>^{/foo}

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 2, 2016, 06:34 UTC
Message-ID: <alpine.DEB.2.20.1607020826530.12947@virtualbox>
In-Reply-To: <xmqqh9cb1ub0.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Wed, 29 Jun 2016, Junio C Hamano wrote:

Show 17 quoted lines

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > When trying to match a pattern in the commit subject, simply skip leading
> > blank lines in the commit message. This is consistent with the
> > pretty-printing machinery: it silently ignores leading blank lines in the
> > commit object's body.
> >
> > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> > ---
> 
> Hmm.
> 
> I just tried
> 
>     $ git commit -s -m '  pull: fast-forward "pull --rebase=true"'
> 
> expecting that ":/^  pull:" would find it ;-)

This patch would try to address a different concern, though:

	git write-object -w --stdin <<-EOF
	tree $(git rev-parse HEAD:)
	parent $(git rev-parse HEAD)
	author B O Gus <bo@gus.com> 1234567890 +0000
	committer F A Ke <fa@ke.org> 1234567890 +0000

	There are two blank lines before the subject
	EOF

It is not about leading whitespace in the commit subject, but about blank lines before it.

Granted, our current tools do not generate such commit objects, but we accept them, and already handle them in some places.

> Also 4/5 is another different class of true bugfix, I would suspect,
> so let's take it on a separate topic that can be merged down to
> older maintainance tracks.

Sure!

Thanks, Dscho