Re: [PATCH v13 04/20] index-helper: new daemon for caching index and related stuff
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 30, 2016, 13:06 UTC
- Message-ID
- <alpine.DEB.2.20.1606301457340.12947@virtualbox>
- In-Reply-To
- <1466914464-10358-4-git-send-email-novalis@novalis.org>
Hi Dave,
On Sun, 26 Jun 2016, David Turner wrote:
Show 22 quoted lines
> diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh
> new file mode 100755
> index 0000000..114c112
> --- /dev/null
> +++ b/t/t7900-index-helper.sh
> @@ -0,0 +1,23 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2016, Twitter, Inc
> +#
> +
> +test_description='git-index-helper
> +
> +Testing git index-helper
> +'
> +
> +. ./test-lib.sh
> +
> +test -n "$NO_MMAP" && {
> + skip_all='skipping index-helper tests: no mmap'
> + test_done
> +}Even when NO_MMAP is empty, there might be no Unix sockets available (such as is the case on Windows). In any case, you really only want to skip these tests when index-helper is not available, so would you mind squashing this patch in?
-- snipsnap -- From: Johannes Schindelin <johannes.schindelin@gmx.de> Subject: [PATCH] fixup! index-helper: new daemon for caching index and related stuff
--- t/t7900-index-helper.sh | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t7900-index-helper.sh b/t/t7900-index-helper.sh index 6c9b4dd..12b5bf7 100755 --- a/t/t7900-index-helper.sh +++ b/t/t7900-index-helper.sh @@ -10,8 +10,10 @@ Testing git index-helper . ./test-lib.sh -test -n "$NO_MMAP" && { - skip_all='skipping index-helper tests: no mmap' +git index-helper -h 2>/dev/null +test $? = 129 || +{ + skip_all='skipping index-helper tests: no index-helper executable' test_done }
-- 2.9.0.270.g810e421