Re: [PATCH 1/1] mingw: work around t2300's assuming non-Windows paths
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 22, 2016, 21:26 UTC
- Message-ID
- <alpine.DEB.2.20.1606222325560.10382@virtualbox>
- In-Reply-To
- <xmqqvb11kmog.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 22 Jun 2016, Junio C Hamano wrote:
Show 14 quoted lines
> Junio C Hamano <gitster@pobox.com> writes: > > > I think I know that well enough; please sanity check. My > > understanding is: > > ... > > The patch under discussion is the only door left for that test, and > > a similar trickery is needed for any end-user scripts used for hooks > > and aliases that use 'git --exec-path', if they ever want to be > > cross-platform. > > > > So let's take that "if Windows do this" change to t2300 as-is. > > Assuming that the sanity check passes, here is a suggested rewrite > to explain the real problem better.
Yes, the sanity check passes, and your commit message is much better than mine.
Thanks! Dscho