Re: [PATCH] mingw: make isatty() recognize MSYS2's pseudo terminals (/dev/pty*)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 27, 2016, 13:33 UTC
Message-ID: <alpine.DEB.2.20.1605271529540.4449@virtualbox>
In-Reply-To: <xmqqvb20wy5x.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Thu, 26 May 2016, Junio C Hamano wrote:

Show 14 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > I do not see this patch in 'pu'... Anything I can do to get this into
> > 'master' eventually?
> 
> The reason why I left it in my inbox was because I couldn't tell if
> this was a final submission with concensus among Git developers on
> Windows, or I should be giving a chance to comment to some folks who
> work on Windows port but are not necessarily closely communicating
> with you.
> 
> If the message were Cc'ed to J6t, I would probably have queued it on
> 'pu' and marked it as "Will merge after waiting for a few days" in
> What's cooking.

Hannes does not use Git for Windows' SDK, but instead uses an old MSys-based development environment that predates even msysGit (which was the SDK used to develop Git for Windows 1.x). His environment most notably does *not* use MinTTY, and therefore is unaffected by the bug that this patch fixes.

That was the entire reasoning why I did not ask Hannes to review this patch: it is unlikely that he knows about the issue, let alone about the correctness of the implementation of this patch.

The implementation relies on some really low-level knowledge of the Windows internals, which Karsten reverse-engineered and I verified.

Thanks, Dscho