Re: [PATCH] commit.c: use strchrnul() to scan for one line

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 16, 2016, 06:12 UTC
Message-ID: <alpine.DEB.2.20.1605160810020.3303@virtualbox>
In-Reply-To: <xmqq37pj55bg.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Sun, 15 May 2016, Junio C Hamano wrote:

Show 13 quoted lines

> diff --git a/commit.c b/commit.c
> index 3f4f371..1f9ee8a 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -415,8 +415,7 @@ int find_commit_subject(const char *commit_buffer, const char **subject)
>  		p++;
>  	if (*p) {
>  		p += 2;
> -		for (eol = p; *eol && *eol != '\n'; eol++)
> -			; /* do nothing */
> +		eol = strchrnul(p, '\n');
>  	} else
>  		eol = p;

ACK. This was my fault, when I introduced the code in 9509af68 (Make git-revert & git-cherry-pick a builtin, 2007-03-01). To be fair, strchrnul() was introduced only later, in 659c69c (Add strchrnul(), 2007-11-09).

Ciao, Dscho