Re: [PATCH] t5510: run auto-gc in the foreground

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 2, 2016, 07:01 UTC
Message-ID: <alpine.DEB.2.20.1605020859131.9313@virtualbox>
In-Reply-To: <20160501153743.323-1-szeder@ira.uka.de>

Hi Gábor,

On Sun, 1 May 2016, SZEDER Gábor wrote:

Show 12 quoted lines

> diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
> index 38321d19efbe..454d896390c0 100755
> --- a/t/t5510-fetch.sh
> +++ b/t/t5510-fetch.sh
> @@ -682,6 +682,7 @@ test_expect_success 'fetching with auto-gc does not lock up' '
>  	(
>  		cd auto-gc &&
>  		git config gc.autoPackLimit 1 &&
> +		git config gc.autoDetach false &&
>  		GIT_ASK_YESNO="$D/askyesno" git fetch >fetch.out 2>&1 &&
>  		! grep "Should I try again" fetch.out
>  	)

Sounds good to me.

Alternatively, we could consider passing `-c gc.autoDetach=false` instead, to limit the scope. I am not insisting on it, of course ;-)

Ciao, Dscho