git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Apr 2016, #07; Mon, 25)

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 28, 2016, 07:58 UTC
Message-ID
<alpine.DEB.2.20.1604280956590.2896@virtualbox>
In-Reply-To
<xmqqmvof9fqw.fsf@gitster.mtv.corp.google.com>
Hi Junio,
On Wed, 27 Apr 2016, Junio C Hamano wrote:
Show 31 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > Hi Junio,
> >
> > On Mon, 25 Apr 2016, Junio C Hamano wrote:
> >
> >> * js/win32-mmap (2016-04-22) 3 commits
> >>   (merged to 'next' on 2016-04-22 at cd39c60)
> >>  + mmap(win32): avoid expensive fstat() call
> >>  + mmap(win32): avoid copy-on-write when it is unnecessary
> >>  + win32mmap: set errno appropriately
> >> 
> >>  mmap emulation on Windows has been optimized.
> >
> > Please note that it is not purely an optimization. It is also a bug fix in
> > case of a pretty full disk: on Windows, mmap() is backed by the page file
> > if it is in copy-on-write mode, and that can fail when the free space on
> > the drive that has the page file drops below a certain threshold.
> 
> Thanks.  How does this look then?
> 
>     * js/win32-mmap (2016-04-22) 3 commits
>       (merged to 'next' on 2016-04-22 at cd39c60)
>      + mmap(win32): avoid expensive fstat() call
>      + mmap(win32): avoid copy-on-write when it is unnecessary
>      + win32mmap: set errno appropriately
> 
>      mmap emulation on Windows has been optimized and work better without
>      consuming paging store when not needed.
> 
>      Will merge to 'master'.
Perfect!
> Reducing paging file consumption still falls into optimization in my
> dictionary, though ;-)

Well, I considered this a bug fix when I worked on it: the command should not have failed, and with my fix, it didn't ;-)

Ciao, Dscho

Previous: Junio C Hamano
Message 4 of 4 in “What's cooking in git.git (Apr 2016, #07; Mon, 25)”
  1. Junio C HamanoApr 25, 2016
  2. Johannes SchindelinApr 27, 2016
  3. Junio C HamanoApr 27, 2016
  4. Johannes SchindelinApr 28, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.