git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase: convert revert to squash on autosquash

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 7, 2016, 15:23 UTC
Message-ID
<alpine.DEB.2.20.1604071720160.2967@virtualbox>
In-Reply-To
<1460041965-31526-1-git-send-email-mst@redhat.com>
Hi,
On Thu, 7 Apr 2016, Michael S. Tsirkin wrote:
> Reverts can typically be treated like squash.  Eliminating both the
> original commit and the revert would be even nicer, but this seems a bit
> harder to implement.

Whoa. This rings a lot of alarm bells, very loudly. It seems you intend to introduce a *major* change in behavior, and all we get to convince us that this is a good change is this puny paragraph (which, by the way, does not do half a good job of explaining to me what you think this patch is supposed to do, let alone of convincing me that what you want is a good change).

So. What is it again that you want to achieve? Please use plain English, e.g. explaining how exactly reverts are typically to be treated like squashes. And please make it convincing, because so far, I am far from convinced.

Ciao, Johannes

Previous: Michael S. TsirkinNext: Michael S. Tsirkin
Message 2 of 9 in “rebase: convert revert to squash on autosquash”
  1. rebase: convert revert to squash on autosquashMichael S. Tsirkin, Apr 7, 2016
  2. Johannes SchindelinApr 7, 2016
  3. Michael S. TsirkinApr 7, 2016
  4. Johannes SchindelinApr 8, 2016
  5. Matthieu MoyApr 8, 2016
  6. Michael S. TsirkinApr 8, 2016
  7. Michael S. TsirkinApr 8, 2016
  8. Michael S. TsirkinApr 9, 2016
  9. Matthieu MoyApr 8, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.