git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] send-email: more meaningful Message-ID

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 6, 2016, 13:08 UTC
Message-ID
<alpine.DEB.2.20.1604061505010.3371@virtualbox>
In-Reply-To
<20160405213607.GA15023@dcvr.yhbt.net>
Hi,
On Tue, 5 Apr 2016, Eric Wong wrote:
Show 30 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
> > Eric Wong <normalperson@yhbt.net> writes:
> > 
> > > Using a YYYYmmddHHMMSS date representation is more meaningful to
> > > humans, especially when used for lookups on NNTP servers or linking
> > > to archive sites via Message-ID (e.g. mid.gmane.org or
> > > mid.mail-archive.com).  This timestamp format more easily gives a
> > > reader of the URL itself a rough date of a linked message compared
> > > to having them calculate the seconds since the Unix epoch.
> > >
> > > Furthermore, having the MUA name in the Message-ID seems to be a
> > > rare oddity I haven't noticed outside of git-send-email.  We
> > > already have an optional X-Mailer header field to advertise for
> > > us, so extending the Message-ID by 15 characters can make for
> > > unpleasant Message-ID-based URLs to archive sites.
> > >
> > > Signed-off-by: Eric Wong <normalperson@yhbt.net>
> > > ---
> > 
> > Sounds like a sensible goal.  Just a few comments.
> > 
> >  - Is it safe to assume that we always can use POSIX::strftime(), or
> >    do we need some fallback?  I am guessing that this is safe, as
> >    POSIX has been part of the core modules for a long time, and the
> >    script does "use 5.008" upfront.
> 
> I'm hoping so :)  And none of the format specifiers used here
> should be subject to locale-dependent weirdness, at least.
> 
> +Cc both Johannes for Windows knowledge.
Thanks.

send-email is implemented as a Perl script, and Git for Windows uses a Perl interpreter for such scripts which uses MSYS2's POSIX emulation layer, i.e. POSIX calls are fine.

Short answer: no problem there, not even on Windows.

Of course, Git for Windows users are much more likely to use a Pull Request based workflow than a mail-based one, so it is even less of a problem for us.

Ciao, Dscho

Previous: Eric WongNext: Eric Wong
Message 4 of 5 in “send-email: more meaningful Message-ID”
  1. send-email: more meaningful Message-IDEric Wong, Apr 5, 2016
  2. Junio C HamanoApr 5, 2016
  3. Eric WongApr 5, 2016
  4. Johannes SchindelinApr 6, 2016
  5. send-email: more meaningful Message-IDEric Wong, Apr 6, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.