Re: [PATCH] rebase -x: do not die without -i

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 17, 2016, 13:11 UTC
Message-ID: <alpine.DEB.2.20.1603171406080.4690@virtualbox>
In-Reply-To: <xmqq4mc535n2.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On Thu, 17 Mar 2016, Junio C Hamano wrote:

> I guess that may "work" but it sounds like quite a roundabout
> way to "test all commits".  "rebase" is about replaying history to
> end up with a set of newly minted commits, and being able to poke at
> the state each commit records in the working tree is a side effect.

I think there is a misunderstanding here. Stefan does not only want to test all of the commits in the patch series. Stefan wants to make sure that all patches in the series result in revisions that pass the test suite.

In other words, it is not only about testing, it is also about fixing when things break.

And that is very, very much the purpose of the interactive rebase.

>     $ git for-each-rev -x "$command" old..new
> 
> where you can write "sh -c 'git checkout $1 && make test' -" as
> your $command.

You meant

	git rev-list old...new |
	while read rev
	do
		$command || break
	done

Again, this might *test* the revisions. But it does nothing to help fixing any patch in the series.

Ciao, Dscho