Re: [PATCH 4/4] remote: use remote_is_configured() for add and rename
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 17, 2016, 16:20 UTC
- Message-ID
- <alpine.DEB.2.20.1602171720130.3152@virtualbox>
- In-Reply-To
- <20160217142455.GC1831@hank>
Hi Tomas,
On Wed, 17 Feb 2016, Thomas Gummerer wrote:
Show 14 quoted lines
> On 02/17, Johannes Schindelin wrote: > > > > diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh > > index 94079a0..19e8e34 100755 > > --- a/t/t5505-remote.sh > > +++ b/t/t5505-remote.sh > > @@ -51,6 +51,11 @@ test_expect_success setup ' > > git clone one test > > ' > > > > +test_expect_success 'add remote whose URL agrees with url.<...>.insteadOf' ' > > + git config url.git@host.com:team/repo.git.insteadOf myremote && > > Minor nit: I think we should use test_config here.
Good point.
-- snipsnap -- From: Johannes Schindelin <johannes.schindelin@gmx.de> Date: Wed, 17 Feb 2016 14:45:59 +0100 Subject: [PATCH] t5505: 'remote add x y' should work when url.y.insteadOf = x
This is the test missing from fb86e32 (git remote: allow adding remotes agreeing with url.<...>.insteadOf, 2014-12-23): we should allow adding a remote with the URL when it agrees with the url.<...>.insteadOf setting.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- t/t5505-remote.sh | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index 94079a0..949725e 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -51,6 +51,11 @@ test_expect_success setup ' git clone one test ' +test_expect_success 'add remote whose URL agrees with url.<...>.insteadOf' ' + test_config url.git@host.com:team/repo.git.insteadOf myremote && + git remote add myremote git@host.com:team/repo.git +' + test_expect_success C_LOCALE_OUTPUT 'remote information for the origin' ' ( cd test &&
-- 2.7.1.windows.2