Re: [PATCH 14/15] git-am.sh: replace using expr for arithmetic operations with the equivalent shell builtin

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 4, 2016, 12:01 UTC
Message-ID: <alpine.DEB.2.20.1602041258400.2964@virtualbox>
In-Reply-To: <CA+EOSB=ky8E7J0Fa26DjgT=5-X9N09=4kRbGvWZo5K7PhwS7hg@mail.gmail.com>

Hi Elia,

On Thu, 4 Feb 2016, Elia Pinto wrote:

Show 11 quoted lines

> 2016-02-04 12:14 GMT+01:00 Johannes Schindelin <Johannes.Schindelin@gmx.de>:
> > Hi Elia,
> >
> > On Thu, 4 Feb 2016, Elia Pinto wrote:
> >
> >> -                     this=$(expr "$this" + 1)
> >> +                     this=$(( "$this" + 1 ))
> >
> > Why the funny spaces? We do not do that anywhere in the existing code
> > except in three places (2x filter-branch, 1x rebase--interactive, all
> > three *not* my fault) and in some tests.

I actually noticed more places now, and will send a quick fixer-upper patch series in a few seconds, that we can hopefully apply before your series?

Thanks, Dscho